Skip to content

chore: remove unused deframe_data deframing utility - #109

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-deframe-data-deframing-utility-a21cdd
Closed

chore: remove unused deframe_data deframing utility#109
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-deframe-data-deframing-utility-a21cdd

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Remove the standalone deframe_data function from _protocol.py and the
five TestMessageFraming tests that exercised it.

The function had no production callers anywhere in the codebase (the only
references were in these tests, which do not count as production
consumers). It was never wired into production — the streaming
read_messages path inlines its own deframing logic and additionally
handles decompression, making deframe_data a superseded standalone
decoder. It is not exported in any __init__.py, not referenced in
docs/examples, and lives in a private module, so there is no external
consumer risk.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner August 25, 2026 22:44
@detail-app
detail-app Bot requested a review from quettabit August 25, 2026 22:44
@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@quettabit

quettabit commented Aug 25, 2026

Copy link
Copy Markdown
Member

maybe we should move that fn into tests or continue to keep it there but signal that its for tests (based on whatever the convention is). can look into that later. so closing this for now.

@quettabit quettabit closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant