chore: remove unused deframe_data deframing utility - #109
Closed
detail-app[bot] wants to merge 1 commit into
Closed
Conversation
|
PR author is not in the allowed authors list. |
Member
|
maybe we should move that fn into tests or continue to keep it there but signal that its for tests (based on whatever the convention is). can look into that later. so closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the standalone
deframe_datafunction from_protocol.pyand thefive
TestMessageFramingtests that exercised it.The function had no production callers anywhere in the codebase (the only
references were in these tests, which do not count as production
consumers). It was never wired into production — the streaming
read_messagespath inlines its own deframing logic and additionallyhandles decompression, making
deframe_dataa superseded standalonedecoder. It is not exported in any
__init__.py, not referenced indocs/examples, and lives in a private module, so there is no external
consumer risk.
History
s2-sdk#1 @quettabit)Dead Code PRs can be configured here.