Send pool DELETE requests without a JSON body - #22
Merged
Merged
Conversation
- Avoid the unused null payload that can close HTTPS responses during Hyper's unread-body handling. - Preserve authentication, TLS verification, deadlines, and JSON response decoding. - Add a deterministic wire regression for empty DELETE/GET bodies and connection reuse, with bounded waits and worker cleanup. - Validate with the full release gate and independent Sol High review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native Rust client sent a four-byte JSON
nullbody with pool DELETE requests. The server's delete handler ignores request bodies, so Hyper could close the TLS connection while the client read the response. On macOS this surfaced asError encountered in a headerwith OS error 22, including scheduled CI run 499.Send DELETE without a request body, like GET. Add a deterministic wire regression that checks both requests have zero body bytes and use the same connection. The test drains unexpected bodies before asserting, so the original client fails on
[4, 0]rather than relying on the intermittent socket race. It bounds accept/read/write waits and joins its worker before client assertions.Diagnosis reproduced the exact macOS error with a valid 29.999802-second socket timeout. A temporary bodyless client passed 2,000 deletes; delaying the original body reproduced the error immediately even though deletion had succeeded. Independently consuming that delayed body on the server removed the failure. This change adds no retries or dependency updates and preserves authentication, TLS verification, and request deadlines.
Validation:
secure_sharing::native_key_connects_and_reuses_server_identitypasses unchanged.just release-gatepasses, includingjust check, format, Clippy, Rust tests, ABI, conformance, language bindings, UI smoke, and package installation smoke.