Answer group edits with the membership they left - #1065
Merged
Merged
Conversation
The lane used Ubuntu 24.04's default clang and libc++ 18. libc++ 18 has no floating-point std::from_chars, so argument_normalization.cpp did not compile there, while the macOS runner's libc++ built it. Ubuntu 24.04 ships clang-20 and libc++-20-dev in its own archive, and a three-line probe in the lane image parses a double through from_chars with them. The image installs those, and the lane configures with clang-20. A build volume whose cached compiler the image no longer has is reconfigured on its own, because CMake does not read CC and CXX again over an existing cache. run.sh also passes DIDI_LOCALCI_RECONFIGURE, which lane.sh documented and never received. Fixes #1026
scene_add_to_group and scene_remove_from_group answered added and removed as constants. Membership was read only before the write, so a commit the node did not take would still have read as done. Both now read is_in_group again after the undo action commits and answer in_group from it. A change the node does not reflect is refused rather than reported. They move from exempt to observed, and a case for each compares in_group with the node's own is_in_group through the witness. Reporting the opposite of what was read fails the harness on both tools. Part of #1019.
github-actions
Bot
added
documentation
9 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #1019: the two group edits.
scene_add_to_groupandscene_remove_from_groupansweredaddedandremovedas constants. Membership was read before the write, to refuse a duplicate or a missing one, and never after it, so a commit the node did not take would still have read as done.Both now read
Node.is_in_groupagain after the undo action commits and answerin_groupfrom that read. A change the node does not reflect is refused with a 500 rather than reported as success.addedandremovedare unchanged for callers that read them.Related Issues
Part of #1019. Stacked on #1064, which merges first.
Type of Change
Checklist
tests/covering new functionality. Two observed-state cases.tests/run_godot_integration.ps1on Godot 4.5.1, 4.6.2 and 4.7.2.didi --dump-tool-manifestfrom the same build, preserves the Phase 4/5/6 contracts, and keeps reserved runtime debugger tools marked unimplemented.docs/SURFACE_AMENDMENTS.md. No new tool.docs/BUILD_QUEUE.mdsaysIN PROGRESS, orCOMPLETE (#<this pull request>). Not a queue item.test_inventory.pyagrees.docs/andREADME.md.Tests
tests/observed_post_state.json: both move from exempt to observed onin_group.tests/observed_post_state.ps1adds a case for each, in the observed scene, comparingin_groupwith the node's ownis_in_groupthrough a newin_groupfunction onobserved_witness.gd. On 4.5.1, 4.6.2 and 4.7.2: 36 cases over 34 tools agreed.scene_add_to_group.in_group answered false but the engine reports true, and the reverse for remove.Local: native 946/946, Python OK, docs validator clean, inventory 1486.