Include LiquidHaskell check in distribution and add acknowledgements - #45
Merged
Merged
Conversation
ninioArtillero
force-pushed
the
xg/update-package
branch
from
August 13, 2026 22:51
a13ff3d to
727713f
Compare
ninioArtillero
changed the title
ninioArtillero
force-pushed
the
xg/update-package
branch
from
August 13, 2026 23:00
727713f to
78a9138
Compare
ninioArtillero
changed the title
ninioArtillero
marked this pull request as ready for review
August 14, 2026 14:44
Collaborator
Author
|
@ddssff Are you fine with this changes? |
Collaborator
Author
|
@ddssff These changes do not seem controversial to me, but I would appreciate your blessing before merging (which I'm planning to do by the start of next week if no concern is raised). |
Member
|
I have no issues with these, thank you for asking! |
Member
|
The homepage url in the cabal file is dead, does anyone have a replacement? |
Contributor
|
The archive seems to have an old version of the link that is good: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff.cabalis updated to includeDiff-liquidhaskell.cabalin the source distribution using theextra-filesfield (which seems to be the appropriate one for this case). This provides users getting the code from the hackage tarball a means to run the static checks. The new field required bumping cabal version to3.14, which in turn required the license field to be updated to a SPDX compliant license (BSD-3-Clause). A url pointing to this package issue tracker was added as well.The licese field is removed from
Diff-liquidhaskell.cabal: being an artificial package to avoid a cyclic dependency, it seems unnecessary to have this field.Tweag's support for writing the LiquidHaskell static checks is aknowledged in the
README.md, and a link to a blog post providing insight into the static checks development is included alongside it.Intances of "Liquid Haskell" are changed to "LiquidHaskell" (without space) to have a single naming convention across the repository.