Skip to content

UI k 5806/divider rebranding #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slizhevskyv-semrush wants to merge 2 commits into
base: UIK-5351/add-more-variables-to-theme
Choose a base branch
from
Open

UI k 5806/divider rebranding #3159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a57f6e
[UIK-5806][divider] divider rebranding
slizhevskyv-semrush Aug 28, 2026
eb26f88
[UIK-5806][divider] divider rebranding
slizhevskyv-semrush Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion semcore/divider/__tests__/divider.browser-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ test.describe(`${TAG.VISUAL} `, () => {
screenshotsClip.y -= 4;
screenshotsClip.width += 8;
screenshotsClip.height += 8;
await expect(page).toHaveScreenshot({ clip: screenshotsClip });
await expect(page).toHaveScreenshot({ clip: screenshotsClip, scale: 'device' });
const divider = page.getByRole('separator');

if (item.orientation == 'horizontal') {
Expand Down
Binary file modified ...amples-Verify-vertical-divider-renders-in-complex-examples-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...xamples-Verify-vertical-divider-renders-in-complex-examples-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...examples-Verify-vertical-divider-renders-in-complex-examples-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ion-horiz-162b3-condary-theme-invert-w-undefined-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...n-horiz-4990a-order-warning-active-w-undefined-h-undefined-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...on-horiz-4990a-order-warning-active-w-undefined-h-undefined-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ion-horiz-4990a-order-warning-active-w-undefined-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ion-horiz-de5b5-primary-theme-invert-w-undefined-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ation-horizontal-use-primary-theme-default-w-100-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ion-horizontal-use-secondary-theme-default-w-100-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...n-verti-c409f-order-warning-active-w-undefined-h-undefined-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...on-verti-c409f-order-warning-active-w-undefined-h-undefined-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ion-verti-c409f-order-warning-active-w-undefined-h-undefined-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ntation-vertical-use-primary-theme-default-w-undefined-h-100-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...entation-vertical-use-primary-theme-invert-w-undefined-h-150-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...tation-vertical-use-secondary-theme-default-w-undefined-h-50-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...tation-vertical-use-secondary-theme-invert-w-undefined-h-200-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
126 changes: 45 additions & 81 deletions semcore/divider/src/style/divider.shadow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,91 +1,55 @@
SDivider {
display: block;
}

SDivider[use='primary'] {
background-color: var(--theme, var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)));
}

SDivider[use='primary']SDivider[theme='default'] {
background: var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161));
}
SDivider[use='primary']SDivider[theme='invert'] {
background-color: var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347));
opacity: 0.2;
}

SDivider[orientation='horizontal']SDivider[use='secondary'] {
background-image: linear-gradient(
to right,
var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 3px,
transparent 1px
);
background-size: 5px 1px;
}

SDivider[orientation='horizontal']SDivider[use='secondary']SDivider[theme='default'] {
background: linear-gradient(
to right,
var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 3px,
transparent 1px
);
background-size: 5px 1px;
}
SDivider[orientation='horizontal']SDivider[use='secondary']SDivider[theme='invert'] {
background-image: linear-gradient(
to right,
var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347)) 3px,
transparent 1px
);
opacity: 0.2;
background-size: 5px 1px;
}

SDivider[orientation='vertical']SDivider[use='secondary'] {
background-image: linear-gradient(
to bottom,
var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 3px,
transparent 1px
);
background-size: 1px 5px;
}

SDivider[orientation='vertical']SDivider[use='secondary']SDivider[theme='default'] {
background-image: linear-gradient(
to bottom,
var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 3px,
transparent 1px
);
background-size: 1px 5px;
}
SDivider[orientation='vertical']SDivider[use='secondary']SDivider[theme='invert'] {
background-image: linear-gradient(
to bottom,
var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347)) 3px,
transparent 1px
);
opacity: 0.2;
background-size: 1px 5px;
}

SDivider[orientation='horizontal'] {
width: 100%;
height: 1px;
}
&[orientation='horizontal'] {
width: 100%;
height: 1px;
}

SDivider[orientation='vertical'] {
width: 1px;
height: auto;
min-height: 100%;
align-self: stretch;
flex-shrink: 0;
}
&[orientation='vertical'] {
width: 1px;
height: auto;
min-height: 100%;
align-self: stretch;
flex-shrink: 0;
}

SDivider[theme]:not([theme='default']):not([theme='invert']) {
&[use='primary'] {
background-color: var(--theme);
background-color: var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161));

&[theme='invert'] {
background-color: var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347));
}
}

&[use='secondary'] {
background-image: linear-gradient(to right, var(--theme) 3px, transparent 1px);
&[orientation='horizontal'] {
background-image: radial-gradient(circle, var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 0.5px, transparent 0.5px);
background-size: 5px 1px;
background-position: -2px 50%;

&[theme='invert'] {
background-image: radial-gradient(circle, var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347)) 0.5px, transparent 0.5px);
}
}

&[orientation='vertical'] {
background-image: radial-gradient(circle, var(--intergalactic-border-primary, oklch(0.137 0.026 175.7 / 0.161)) 0.5px, transparent 0.5px);
background-size: 1px 5px;
background-position: 50% -2px;

&[theme='invert'] {
background-image: radial-gradient(circle, var(--intergalactic-border-primary-invert, oklch(0.995 0.009 144.4 / 0.347)) 0.5px, transparent 0.5px);
}
}
}

&[theme]:not([theme='default']):not([theme='invert']) {
&[use='primary'] {
background-color: var(--theme);
}
&[use='secondary'] {
background-image: radial-gradient(circle, var(--theme) 0.5px, transparent 0.5px);
}
}
}
2 changes: 0 additions & 2 deletions stories/components/divider/tests/examples/divider-styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { NSBox } from '@semcore/ui/base-components';
import { Flex } from '@semcore/ui/base-components';
import Divider from '@semcore/ui/divider';
import type { NSDivider } from '@semcore/ui/divider';
Expand All @@ -24,7 +23,6 @@ const Demo = (props: DividerStylesExample) => {
);
};
export const baseExampleProps: DividerStylesExample = {

orientation: 'horizontal',
use: 'primary',
theme: 'default',
Expand Down
Loading