incertae_sedis should never be "" - #328
Merged
Merged
Conversation
lmrodriguezr
force-pushed
the
incertae-sedis-should-never-be-empty-string
branch
from
August 20, 2026 22:40
91cfc03 to
b6acf3d
Compare
lmrodriguezr
force-pushed
the
incertae-sedis-should-never-be-empty-string
branch
from
August 20, 2026 22:44
b6acf3d to
ef3b985
Compare
lmrodriguezr
marked this pull request as ready for review
August 20, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
Name#incertae_sedisandPlacement#incertae_sedisis set to an empty string""when a regular placement is created. This leads to other weird issues down the line. This pull requests adds a validation enforcingincertae_sedisto be either present ornil.Requires clean-up in production of existing
""values.Must be rebased after #327 is merged.