Record deletions as delta patches with in-place compaction - #357
Draft
nabeya11 wants to merge 4 commits into
Draft
Record deletions as delta patches with in-place compaction#357nabeya11 wants to merge 4 commits into
nabeya11 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## perf/patch-append #357 +/- ##
=====================================================
+ Coverage 46.49% 48.28% +1.79%
=====================================================
Files 9 9
Lines 1624 1690 +66
=====================================================
+ Hits 755 816 +61
- Misses 815 816 +1
- Partials 54 58 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deletion now compacts the cloud in place, keeping the spare capacity of Data, and records only the removed points. Undo re-expands with a backward walk, without allocation when the capacity is still available. This replaces the last snapshot-fallback edit; the whole-cloud replacePatch remains only for re-import and full voxel_grid. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nabeya11
force-pushed
the
perf/patch-undo
branch
from
August 22, 2026 10:52
7c2347c to
2a11a99
Compare
nabeya11
changed the title
The subtest exercises revert without spare capacity; the reallocation branch is only reached when points were actually removed, so name it after the setup rather than the branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adapt deletePatch to the encodeHead/payload interface; its points are now copied straight to the JS heap when pushed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Deletion (editor's passThrough / passThroughByMask) now compacts the cloud in place and records only the original positions and contents of the removed points.