CI: clear the Node 20 deprecation - #2
Merged
Conversation
- Bump actions/checkout and actions/upload-artifact from v4 to v7. Both were being force-run on Node 24; v7 is the current major and targets it natively. - Drop ilammy/msvc-dev-cmd and set up the MSVC environment inline with vswhere and vcvars64. The action has no Node 24 release, so pinning it any way still tripped the deprecation, and this removes a third-party dependency from the build path. It locates the toolchain the same way the MSBuild step does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
Node.js 20 is deprecatedannotation that was appearing on every run.actions/checkoutandactions/upload-artifact: v4 → v7. Both were being force-run on Node 24; v7 is the current major and targets it natively. (v5 would also clear the warning, but it is already two majors behind.) Our usage is justname/path/if-no-files-found, which is unchanged across those majors.ilammy/msvc-dev-cmd. It has no Node 24 release — latest isv1.13.0, still declaring node20 — so no pin could clear it. The MSVC environment is now set up inline withvswhere+vcvars64.bat, the same way the MSBuild step below it already locates the toolchain. This also removes a third-party dependency from the build path.Verified
CI is green on this branch with no annotations at all, and the checks still run for real rather than passing vacuously:
No application code is touched.