feat: align select and pen gestures with standard outline editing - #466
Merged
Merged
Conversation
A segment is selected when the marquee touches its curve, except when exactly one of its end points is inside: boxing a point keeps selecting that point alone rather than the segments leaving it.
Dragging from an open end pulls the next segment's first handle. From a line the handle is free and the point stays a corner; Option keeps it on the line's direction and makes the point smooth. From a curve the incoming handle mirrors it. The pulled handle stays drawn and shapes the next dragged curve; a click still draws a line and drops it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Curve.intersectsRectto@shift/geo.Issue
Closes #465
Refs #369
Testing
pnpm checkpassed.pnpm typecheckandpnpm lint:checkpassed.npx vitest runinapps/desktop: 1166 tests passed, including new regression tests inSelectMove.test.ts,Select.test.ts, andPen.test.ts.npx vitest runinpackages/geo: passed, including newCurve.intersectsRecttests.glyph-rendering.spec.ts(pen-cubic-curve,pen-s-curve-handles,pen-smooth-junction-drag-preview). Each diff is only the newly drawn pending handle: from the last point between gestures, and from the start of the curve being dragged. The baselines were replaced with the CI-rendered images after inspecting every diff.🤖 Generated with Claude Code