fix: give unstyled text the theme's primary colour - #469
Open
kostyafarber wants to merge 2 commits into
Open
kostyafarber wants to merge 2 commits into
kostyafarber wants to merge 2 commits into
Conversation
Nothing set a base text colour, so any text without its own colour class fell back to the browser's colour-scheme default: pure white in dark themes instead of the palette's foreground.
kostyafarber
added
the
ci: update visual snapshots
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
body { color: var(--color-primary) }, so text without its own colour class follows the active theme. Previously it fell back to the browser'scolor-schemedefault, pure white in dark themes, instead of the palette's foreground (e.g. cream in warm dark palettes).#000to#171717, so visual baselines are regenerated.Issue
No issue — small theming fix found while reviewing #468.
Testing
pnpm checkci: update visual snapshots🤖 Generated with Claude Code