feat: adapt the launcher lockup and accent text to colour themes - #474
Merged
Merged
Conversation
Shift Light keeps the channel-coloured lid; other themes fill the ghost with a tint of their text colour. Each colour is one path rendered with crisp edges, removing hairline seams between pixel blocks. Release now wears the forward cap and Nightly the backward one.
Text on accent buttons now picks the palette's lightest colour instead of pure white, and prefers it within 20% of the best WCAG contrast. Solarized's blue gets its light base and Gruvbox Light's teal its cream.
kostyafarber
added
the
ci: update visual snapshots
kostyafarber
added
the
release: nightly
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--color-logo-lid/--color-logo-bodywith the Shift Light colours as fallbacks, and oneindex.cssrule sets them for anydata-color-themeother thanshift-light.crispEdges, so adjacent pixel blocks no longer show the background between them.--color-on-accentnow chooses between the palette's lightest and darkest colours instead of pure white. The light colour wins when its contrast is within 20% of the best, because WCAG contrast over-favours dark text on mid-tone accents. Solarized's blue now gets itsbase3light text, and Gruvbox Light's teal its cream. All other themes are unchanged, and Shift Light still uses theindex.cssdefault.Issue
No issue — visual polish to the launcher lockup and theme contrast. Refs #406
Testing
pnpm checkpassed (typecheck, lint, 1189 desktop tests)lib/themes/index.test.tsasserts the Solarized and Gruvbox Light accent text colourslanding.spec.ts›landing-default.pngis an interface golden compared only on CI; the Shift Light lockup now renders with crisp edges and the forward cap, so the baseline needs regenerating via theci: update visual snapshotslabel. E2E not run locally.🤖 Generated with Claude Code