Move each helper to the package that uses it, and drop short mode - #19
Merged
Conversation
TakeJsonFlag sat in dispatch with all five of its callers outside it, so every part imported dispatch for that one function. It moves down into internal/api, which is where CLAUDE.md says shared work goes, and no part imports another package now beyond api. TakeServerFlag has one caller, inside Dispatch, so it stops being exported. ValidImei had all three of its callers in internal/device and moves there.
--server / trimmed to nothing and then blamed the network: "the server could not be reached, check your connection". --server= said "--server needs an address", which is what both should say. The address is now trimmed before it is tested for emptiness, so every way of writing an empty one reaches the same message.
Go caches per package, and the cached result is keyed on the linked test binary, so a change to one part leaves the others cached and only a change the login tests link re-runs their thirty seconds. -short skipped those same tests on a flag typed by hand, which gets it wrong in exactly the run where login is what you edited. The README intro promised uploading Lua code and streaming logs. Both print "is not available yet", so it now says what the tree has and names the two that are coming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TakeJsonFlag sat in dispatch with all five of its callers outside it, so every
part imported dispatch for that one function. It moves down into internal/api,
where CLAUDE.md says shared work goes, and nothing under internal imports
dispatch any more: the graph is dispatch -> api and every part -> api.
TakeServerFlag has one caller, inside Dispatch, so it stops being exported, and
ValidImei had all three of its callers in internal/device and moves there.
--server / trimmed to nothing and then blamed the network, while --server= said
what was actually wrong. The address is now trimmed before it is tested for
emptiness, so /, //, =/, an empty value and a missing one all reach the same
message.
Go caches per package, and the cached result is keyed on the linked test
binary, so a change to one part leaves the others cached and only a change the
login tests link re-runs their thirty seconds. -short skipped those same tests
on a flag typed by hand, which gets it wrong in exactly the run where login is
what you edited, so it is gone along with the three places it was documented.
The README intro promised uploading Lua code and streaming logs. Both print
"is not available yet", so it now says what the tree has and names the two that
are coming.
No version change, and nothing under .github, flake.nix, .goreleaser.yaml or
go.mod is touched.