LT-22642: Make reversal configuration switching update the view - #1107
Merged
Conversation
Gitlint's B5 rule rejects a body under 20 characters. The guidelines listed the other body rules but not this one, so a short body failed CI with no documented reason.
Switching between two reversal configurations of the same writing system left the view and the pane bar label unchanged, and choosing a configuration in the Configure Reversal Index dialog left the label, the dropdown checkmark and the entry list disagreeing. The two properties describing the current reversal are kept in sync across a many-to-one mapping: the index guid comes from the configuration's writing system, so two configurations of one writing system select the same index. Arm m_updateContentLater only when the index actually changes. Otherwise no clerk reload follows, ActiveClerkSelectedObject never arrives, and the deferred UpdateContent never runs. Validate the configuration against ReversalIndexGuid rather than the clerk's current entry, which can still belong to the index being left during a reload, so an explicit choice survives. Sync the guid in RefreshAllContent. The Configure dialog saves the chosen configuration without broadcasting, so nothing else points the guid at the index it names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
=======================================
Coverage 38.34% 38.35%
=======================================
Files 1507 1507
Lines 350586 350617 +31
Branches 40294 40298 +4
=======================================
+ Hits 134432 134475 +43
+ Misses 186927 186912 -15
- Partials 29227 29230 +3
🚀 New features to boost your workflow:
|
thejambi
marked this pull request as ready for review
August 25, 2026 14:15
mark-sil
approved these changes
Aug 25, 2026
mark-sil
left a comment
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on thejambi).
thejambi
added a commit
that referenced
this pull request
Aug 25, 2026
* Document the minimum commit body length gitlint enforces Gitlint's B5 rule rejects a body under 20 characters. The guidelines listed the other body rules but not this one, so a short body failed CI with no documented reason. * Merge remote-tracking branch 'origin/main' into bugfix/LT-22642 * Fix LT-22642: Make reversal configuration switching update the view Switching between two reversal configurations of the same writing system left the view and the pane bar label unchanged, and choosing a configuration in the Configure Reversal Index dialog left the label, the dropdown checkmark and the entry list disagreeing. The two properties describing the current reversal are kept in sync across a many-to-one mapping: the index guid comes from the configuration's writing system, so two configurations of one writing system select the same index. Arm m_updateContentLater only when the index actually changes. Otherwise no clerk reload follows, ActiveClerkSelectedObject never arrives, and the deferred UpdateContent never runs. Validate the configuration against ReversalIndexGuid rather than the clerk's current entry, which can still belong to the index being left during a reload, so an explicit choice survives. Sync the guid in RefreshAllContent. The Configure dialog saves the chosen configuration without broadcasting, so nothing else points the guid at the index it names. Co-Authored-By: Zachary Burnham <zachary_burnham@sil.org> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
Switching between two reversal configurations of the same writing
system left the view and the pane bar label unchanged, and choosing a
configuration in the Configure Reversal Index dialog left the label,
the dropdown checkmark and the entry list disagreeing.
The two properties describing the current reversal are kept in sync
across a many-to-one mapping: the index guid comes from the
configuration's writing system, so two configurations of one writing
system select the same index.
Arm m_updateContentLater only when the index actually changes.
Otherwise no clerk reload follows, ActiveClerkSelectedObject never
arrives, and the deferred UpdateContent never runs.
Validate the configuration against ReversalIndexGuid rather than the
clerk's current entry, which can still belong to the index being left
during a reload, so an explicit choice survives.
Sync the guid in RefreshAllContent. The Configure dialog saves the
chosen configuration without broadcasting, so nothing else points the
guid at the index it names.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
CI-ready checklist
.github/commit-guidelines.md.build.ps1,test.ps1, or MSBuild).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.Notes for reviewers (optional)
This change is