TT-7621 fix: offer Record once the reference audio stops

[nabalone]

Fix 3 of the PBT series. Into #527.

The fault

Pausing the reference playback part way through left Record disabled with no way forward but replaying the whole clause.

allowRecord needs currentClausePlayed and phase 'recordReady', and handleRegionPlayEnd was the only thing that set them — so the step depended on a region-out that does not always come. A user pause has none by definition.

The fix

The step now treats the reference audio stopping as the signal that the clause has been heard — which is the thing the user actually did. A stop reported within 250ms of playback starting is the seek that started it rather than the audio, so those are ignored; auto-segmenting never produces a clause anywhere near that short.

Also fixes the waveform selection and the segment label disagreeing after a segment is selected, which came from the same stranded state.

Deliberately not fixed here

Record stays operable while a clicked segment plays is still red. I tried it on this branch and backed it out: the cause is a spurious park (wavesurfer emits the clicked clause's region-out during the seek, ~10ms in, so the step parks on a segment that is about to play). Suppressing that park does fix Record, but it then strands the click flow entirely — playback started by clicking a segment is not region-bounded and reports neither a region-out nor a stop, so nothing ever re-enables Record. Shipping that would trade a wrong-enabled button for a dead end.

The honest fix is at the player level: a segment click should start region-bounded playback that reports its end like playCurrentClause does. Worth its own ticket — it also means clicking a segment currently plays past it into the following audio.

Verification

• defects spec: pause test now green
• selection spec: 5 of 7 green (remaining: swallowed adjacent click — fixed in TT-7621 fix: act on a segment click instead of swallowing it #528 — and Record-during-playback, above)
• behaviour specs: 13 + 16 green
• jest PassageDetailCarefulSpeech: 24 green (this touches shared guided-record code)

🤖 Generated with Claude Code

[nabalone]

Claude opened this but I don't think we actually want this change in behavior

[nabalone]

Actually, asking the team

[nabalone]

We decided that for now we do want to make this change and allow recording after a pause. And then when we raise it to the product owners, if they object we can back it back out

[Copilot]

Pull request overview

Adjusts the Phrase Back Translation (PBT) guided recording flow so Record becomes available when reference playback stops (e.g., user pauses), eliminating a dead-end where the step previously depended on a region-out event that may never fire. This aligns the step’s state machine with actual user intent (“I stopped playback, so I’m done listening to this clause”) and updates Cypress specs accordingly.

Changes:

• Treat “source audio stopped” as a clause-heard signal (with a short suppression window to ignore seek-induced stop events).
• Update CT coverage: convert the “pause strands Record” repro from a known-defect test into a passing regression test.
• Tag the still-known defect around out-of-order segment navigation in the selection spec so it can be filtered as a known defect.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/renderer/src/components/PassageDetail/PassageDetailPhraseBackTranslate.selection.cy.tsx	Tags an existing defect repro as @known-defect to keep normal CT runs meaningful.
src/renderer/src/components/PassageDetail/PassageDetailPhraseBackTranslate.defects.cy.tsx	Converts the “pause leaves Record disabled” case into a passing regression assertion.
src/renderer/src/components/PassageDetail/PassageDetailGuidedPhraseRecord.tsx	Implements stop-based progression to recordReady and currentClausePlayed, with seek-stop suppression.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.