TT 7344 pending retry ux - #538
Draft
gtryus wants to merge 3 commits into
Draft
Conversation
…load progress on retry. Retry all is only offered when two or more files are queued, and a successful retry now reports the same uploadComplete snackbar as a normal save. Co-authored-by: Cursor <cursoragent@cursor.com>
gtryus
marked this pull request as draft
August 25, 2026 19:55
gtryus
marked this pull request as ready for review
August 25, 2026 20:44
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the pending media upload retry experience in the React renderer’s Team UI by addressing TT-7344 (incorrect “Retry all” visibility) and TT-7364 (no visible progress / silent success).
Changes:
- Added small pure helpers for “Retry all” visibility and progress-label formatting.
- Updated
PendingUploadsDialogto conditionally render “Retry all”, show a busy-state progress indicator, and snackbar a success message per completed retry. - Added Jest tests for the helper module and basic dialog rendering / single-retry success snackbar.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/renderer/src/components/Team/pendingUploadsDialogHelpers.ts | Adds pure helpers for “Retry all” visibility and progress label formatting. |
| src/renderer/src/components/Team/pendingUploadsDialogHelpers.test.ts | Unit tests for the new helper functions. |
| src/renderer/src/components/Team/PendingUploadsDialog.tsx | Implements conditional “Retry all”, busy progress UI, and success snackbars during retries. |
| src/renderer/src/components/Team/PendingUploadsDialog.test.tsx | Adds dialog tests for “Retry all” visibility and single-retry success snackbar. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return count > 1; | ||
| } | ||
|
|
||
| /** Determinate retry progress, 1-based current index (TT-7364). */ |
Comment on lines
+134
to
+138
| it('shows Retry all when more than one pending file is listed (TT-7344)', () => { | ||
| appendPendingMediaUpload({ | ||
| localAbsolutePath: '/a/audio.mp3', | ||
| fileSize: 10, | ||
| uploadType: UploadType.Media, |
Comment on lines
+170
to
+174
| if (success) { | ||
| retryDoneRef.current += 1; | ||
| setRetryProgress({ | ||
| completed: retryDoneRef.current, | ||
| total: retryTotalRef.current, |
…ss and error handling
Comment on lines
+158
to
162
| // Synchronous by contract: nextUpload calls cb without awaiting it, so | ||
| // anything after an await here would be stranded on a rejection -- | ||
| // leaving busy stuck and the rest of the retry queue unprocessed. | ||
| cb: (_n, success, data) => { | ||
| const sid = (data as { stringId?: string } | undefined)?.stringId; |
| : 0 | ||
| } | ||
| /> | ||
| {retryProgress.total > 1 && ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs
Design
Red-green slices
Files: PendingUploadsDialog.tsx (+ new PendingUploadsDialog.test.tsx and a small helper module), localization only if we add a dedicated “Uploading pending file…” string; prefer existing uploadComplete first.