Enable R8 obfuscation for production builds - #5921
Draft
siddh1004 wants to merge 8 commits into
Draft
Conversation
… into renovate/agp
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [com.android.lint](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | `9.3.2` → `9.4.0` |  |  | | [com.android.library](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | `9.3.2` → `9.4.0` |  |  | | [com.android.application](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | `9.3.2` → `9.4.0` |  |  | --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/simpledotorg/simple-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC40OS4wIiwidXBkYXRlZEluVmVyIjoiNDQuNTcuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: sagarwal <sagarwal@rtsl.org>
… into SIMPLEMOB-59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: SIMPLEMOB-59
View Jira ticket
Google Play reported 0% obfuscation for the
2026.09.03release.Production builds run R8, but the global
-dontobfuscaterule inproguard-rules.proprevented any classes from being obfuscated.This change enables R8 obfuscation while preserving the names of generated Room DAO implementation classes, which are required by the SQL performance profiling instrumentation.
Changes
-dontobfuscaterule.-keepnames class **_RoomDao_ImplWhy
The SQL performance profiler uses generated Room DAO class names when reporting database operations to Sentry. Keeping these names allows the existing performance profiling functionality to continue identifying DAO operations after R8 obfuscation.
Validation
*_RoomDao_Implclasses retain their original names.testQaDebugUnitTest: 2380/2380 tests passedlint: passedgit diff --check: passedThe SQL performance profiler itself was not tested end-to-end on a device as part of this change.