Skip to content

feat(workflow): deploy workflows from resource panel - #6338

Open
BillLeoutsakosvl346 wants to merge 11 commits into
stagingfrom
feat/deploy-workflow-resource-panel
Open

feat(workflow): deploy workflows from resource panel#6338
BillLeoutsakosvl346 wants to merge 11 commits into
stagingfrom
feat/deploy-workflow-resource-panel

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a compact Deploy action to workflow resource tabs on the Home resource panel. It reuses the editor deployment controller, readiness checks, permission handling, deployment mutation, and existing DeployModal.

No backend, API, schema, or migration changes are included.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other

Testing

  • Focused deployment suite: 14 tests passed across 3 files (new compact Deploy coverage plus existing readiness/lock tests).
  • cd apps/sim && bun run type-check: passed.
  • cd apps/sim && bun run lint:check: passed with existing unrelated Zoho suppression warnings.
  • bun run check:client-boundary: passed.
  • bun run check:icon-paths: passed.
  • Full app suite: 1,471 test files passed, 20,219 tests passed, 25 skipped; 4 unrelated pre-existing fixture/environment failures in Python code-placeholder and Fellows fixture tests.
  • Browser smoke test could not run because no browser session was available in the execution environment.

Review focus: resource-panel action placement, compact accessibility labels/tooltips, lock/permission disabled state, and reuse of the existing deployment modal.

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • No new warnings introduced
  • CLA confirmation requires maintainer/reviewer completion

Screenshots/Videos

Browser screenshots were not available because the execution environment exposed no browser session.

@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Error Error Aug 7, 2026 12:45am

Request Review

@cursor

cursor Bot commented Aug 6, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Reuses existing deployment hooks and modal but wires deploy into Home embedded workflows with lock/permission gating; incorrect readiness or lock logic could block deploy or allow it when inappropriate.

Overview
Adds a compact deploy control next to run/open on embedded workflow tabs in the Home resource panel, so users can deploy without opening the full workflow editor.

The shared Deploy component gains a compact mode: upload icon, subtle styling, and **aria-label**s (Deploy / Live / Update) with the same tooltips and DeployModal flow as the editor panel. Registry loading is tightened so deploy stays disabled until hydration is ready and the registry’s active workflow matches the tab’s workflow.

EmbeddedWorkflowActions loads workflow/folder maps, disables deploy when the workflow is effectively locked (or maps are still loading), and passes workspace permissions into Deploy. New deploy.test.tsx covers compact labels, disabled cases, and modal open behavior.

Reviewed by Cursor Bugbot for commit 1b58be2. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds a compact Deploy action to workflow resource tabs while reusing the editor’s deployment controller and modal. The latest changes also address both previously reported findings:

  • Deployment remains disabled until workflow and folder lock metadata finish loading.
  • The new test imports Deploy through the established application alias.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the lock-metadata loading guard and absolute test import address the previously reported issues.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/resource-content.tsx Adds the compact Deploy action and disables it while lock metadata is loading or the workflow is effectively locked.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/deploy.tsx Adds compact icon rendering, accessible labeling, external disabled-state support, and workflow-specific hydration checks while retaining the existing deployment flow.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/deploy.test.tsx Covers compact labels, disabled states, and modal opening using the repository’s configured absolute import alias.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workflow resource tab] --> B[Load workflow and folder maps]
  B --> C{Loading or effectively locked?}
  C -->|Yes| D[Disable compact Deploy]
  C -->|No| E[Run deployment readiness checks]
  E --> F[Deployment mutation]
  F --> G[Existing DeployModal]
Loading

Reviews (4): Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." | Re-trigger Greptile

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 78171b7. Configure here.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant