Skip to content

chore(scripts): drop the script unit tests and the exports that served them #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waleedlatif1 wants to merge 1 commit into from
Closed

chore(scripts): drop the script unit tests and the exports that served them #6343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"check:cron-parity": "bun run scripts/check-cron-parity.ts",
"check:api-validation:strict": "bun run scripts/check-api-validation-contracts.ts --check --enforce-boundary-baseline",
"check:realtime-prune": "bun run scripts/check-realtime-prune-graph.ts",
"check:tool-request-boundary": "bun test scripts/check-tool-request-boundary.test.ts && bun run scripts/check-tool-request-boundary.ts",
"check:tool-request-boundary": "bun run scripts/check-tool-request-boundary.ts",

@greptile-apps greptile-apps Bot Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Boundary scanner coverage removed

The gate now scans only the current production tree, so it no longer exercises controlled cases for direct, computed, optional, aliased, and destructured request access. A later scanner regression can therefore leave CI green while missing prohibited access or rejecting valid request objects.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"check:tool-registry-boundary": "bun run scripts/check-tool-registry-boundary.ts",
"check:sql-date-binding": "bun test scripts/check-sql-date-binding.test.ts && bun run scripts/check-sql-date-binding.ts",
"check:zustand-v5": "bun run scripts/check-zustand-v5-selectors.ts",
Expand Down
200 changes: 0 additions & 200 deletions scripts/check-migrations-safety.test.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/check-migrations-safety.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ const ANNOTATE_GUIDANCE =
'is a contract-phase op. Confirm the old code no longer reads/writes it (it must have shipped in an earlier deploy — not this same PR), then acknowledge with a `-- migration-safe: <reason>` comment on the line above.'

/** Lint a single migration's SQL. Returns only actionable findings. */
export function lintSql(content: string): Finding[] {
function lintSql(content: string): Finding[] {
const lines = content.split('\n')
const statements = parseStatements(content)
const createdTables = new Set<string>()
Expand Down
37 changes: 0 additions & 37 deletions scripts/check-tool-request-boundary.test.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/check-tool-request-boundary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function isLikelyToolIdentifier(expression: SyntaxNode): boolean {
)
}

export function findToolRequestBoundaryViolations(source: string, file = 'source.ts'): Violation[] {
function findToolRequestBoundaryViolations(source: string, file = 'source.ts'): Violation[] {
const extension = extname(file)
const syntaxTree = parse(source, {
sourceFilename: file,
Expand Down