Repository navigation
fix(indexer): align embedding batch size with encoder contract - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowledge could send up to 64 texts to
/embed, while the existing Admin encoder accepts at most two, causing largerindex reconcileruns to fail with422 invalid_request.Split missing embeddings into requests of at most two texts and enforce the same 1–2 text limit in
Clients.embed(). Vector reuse, reconciliation, Qdrant upsert batches and delete ordering remain unchanged. The encoder repository is unchanged.Regression tests cover multiple encoder requests for seven new chunks, correct vector/payload association, failure on the second embedding request before any upsert, and client batch-size bounds.
Validation:
pytest: 77 passed.ruff check .: passed.ruff format --check .: passed.git diff --check: passed.Follow-up to merged PR #1.