ci: bind package-path workflow input before shell use - #168
Merged
joncinque merged 1 commit intoAug 6, 2026
Conversation
Move inputs.package-path into step env before bash interpolation in publish-rust.yml and publish-js.yml. Co-authored-by: Cursor <cursoragent@cursor.com>
joncinque
approved these changes
Aug 6, 2026
joncinque
left a comment
joncinque
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution! This variable isn't actually susceptible to the injection attack since it comes from a choice, but it can't hurt to do the right thing
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Aug 6, 2026
Contributor
Author
|
Thanks for the reviews and merges across the program repos, @joncinque. Happy to pick up anything adjacent if it ever comes up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binds
inputs.package-pathinto stepenv:before shell use inpublish-rust.ymlandpublish-js.yml.Context
GitHub Actions expands
${{ inputs.* }}before the shell runs. Binding throughenv:keeps the value out of the script text when computingTARGET.Test plan
TARGETfrompackage-pathMade with Cursor