Skip to content

Remove unused code - #350

Merged
solid-illiaaihistov merged 2 commits into
solid-software:masterfrom
solid-illiaaihistov:refactor/remove-unused-code
Aug 28, 2026
Merged

Remove unused code#350
solid-illiaaihistov merged 2 commits into
solid-software:masterfrom
solid-illiaaihistov:refactor/remove-unused-code

Conversation

@solid-illiaaihistov

@solid-illiaaihistov solid-illiaaihistov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor

    • Removed obsolete internal parameter-ordering data structures.
    • Simplified the documentation generation workflow without changing its output.
  • Chores

    • Added lint suppression directives to support existing documentation and type utilities.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d8afe97b-adf6-42b6-bdb4-e6d07ee19963

📥 Commits

Reviewing files that changed from the base of the PR and between 27bdc14 and 322ac54.

📒 Files selected for processing (5)
  • lib/src/lints/named_parameters_ordering/models/parameter_info.dart
  • lib/src/lints/named_parameters_ordering/models/parameter_ordering_info.dart
  • lib/src/utils/docs_parser/utils/parser_extensions.dart
  • lib/src/utils/types_utils.dart
  • tool/generate_markdown_docs.dart
💤 Files with no reviewable changes (2)
  • lib/src/lints/named_parameters_ordering/models/parameter_info.dart
  • lib/src/lints/named_parameters_ordering/models/parameter_ordering_info.dart

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes two named-parameter model classes, adds undead analysis directives to two utility files, and removes the unnecessary async modifier from the documentation generator entry point.

Changes

Cleanup updates

Layer / File(s) Summary
Remove obsolete models and update analysis directives
lib/src/lints/named_parameters_ordering/models/parameter_info.dart, lib/src/lints/named_parameters_ordering/models/parameter_ordering_info.dart, lib/src/utils/docs_parser/utils/parser_extensions.dart, lib/src/utils/types_utils.dart
The two parameter model classes were deleted. Undead directives were added to the utility files.
Simplify documentation generator entry point
tool/generate_markdown_docs.dart
The top-level main function no longer uses async.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 322ac

This change removes unused code and makes small cleanup-only adjustments without introducing an actionable merge-blocking risk. It is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing unused classes and code-related declarations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solid-illiaaihistov
solid-illiaaihistov merged commit 4bccd32 into solid-software:master Aug 28, 2026
2 checks passed
@solid-illiaaihistov
solid-illiaaihistov deleted the refactor/remove-unused-code branch August 28, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants