reimplement OpenSHC::Text::FontSizeClass - #214
Merged
Merged
Conversation
TheRedDaemon
added
the
in progress
Contributor
|
Do you want my review at this point, or is your review request for later? I see no .hpp files in the changed files list to update in Ghidra. |
TheRedDaemon
force-pushed
the
reimpl/font-size-class
branch
from
September 3, 2026 22:37
10623df to
a466e27
Compare
Contributor
Author
|
I usally assign you out of habit... will not do this in the future. No, as long as it is "in progress" and I say nothing else, nothing has to be done from you side for now. |
TheRedDaemon
added
declaration/type change
Contributor
Author
|
@gynt Now it can receive the declaration updates. 🙂 |
TheRedDaemon
force-pushed
the
reimpl/font-size-class
branch
from
September 30, 2026 20:52
3185959 to
571fc39
Compare
TheRedDaemon
removed
the
declaration/type change
TheRedDaemon
marked this pull request as ready for review
September 30, 2026 21:01
gynt
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.