test: add StringSlice Append coverage - #504
Merged
Merged
Conversation
tomasaschan
approved these changes
Aug 22, 2026
tomasaschan
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! I don't see any issues with those change, but I'm curious: any particular reason for sending us this patch?
Author
I was looking through the SliceValue implementations and their tests to better understand the codebase, and noticed that Append is implemented for stringSliceValue but didn't appear to have direct test coverage. |
tomasaschan
approved these changes
Sep 6, 2026
Author
|
Thanks for reviewing and merging! @tomasaschan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for StringSlice SliceValue.Append.
This follows the existing SliceValue Replace coverage pattern
and only adds tests without changing runtime behavior.
Test:
go test ./...