Fix typos in bin/ docstrings and a stray character that breaks fork_counter.py - #16
Open
Avicennasis wants to merge 1 commit into
Open
Fix typos in bin/ docstrings and a stray character that breaks fork_counter.py#16Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 typos in
bin/. Each string was verified against livemastercontent before editing.Y# Copyright 2011 Splunk, Inc.-># Copyright 2011 Splunk, Inc.Functions for retriveing settigs from splunkgit conf file.->Functions for retrieving settings from splunkgit conf file.This script polls usefull github data from github->This script polls useful github data from githubPlease review carefully - the first one is a real bug, not a typo
bin/fork_counter.pycurrently starts with a strayYbefore the copyright comment. Python parses that line as the expression statementYfollowed by a comment, so the file compiles but raisesNameError: name 'Y' is not definedas soon as it is imported:Removing the stray character makes the module importable again. Nothing else in the repo currently references
fork_counter/ForkCounter, so this change cannot regress any existing caller.The other two changes are docstring-only.
Deliberately not changed
lib/joblib/- that is a vendored copy of the upstream joblib library (it ships its own test suite and module docs). 13 of the reported typos live there and belong upstream, not in this repo.GithubAPI._link_header_value_for_reletion- the misspelling is a method name, and renaming an identifier is out of scope for a typo PR.