fix(config): support list options from environment variables - #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1383
Summary
Register every list-valued AppConfig option with the config crate environment parser. Environment variables now accept space-separated lists for sqlite_extensions, oidc_protected_paths, oidc_public_paths, and oidc_additional_trusted_audiences. The configuration reference documents the environment syntax.
Stripped verification logs
Full
cargo testpassed: 175 unit tests and 73 integration tests.cargo clippy --all-targets --all-features -- -D warningsandcargo fmt --all -- --checkalso passed.