Approve the bump PR's own build, and correct the parser-retention story - #52
Merged
Conversation
nightly.yml opens the bump PR partly so that "the push-triggered build.yml [gets] a chance to disagree". It does not get one. GitHub gates workflow runs from first-time contributors -- this repository's policy is `first_time_contributors`, read back from /actions/permissions/fork-pr-contributor-approval -- and github-actions[bot] counts as one, so the pull_request run on a bump branch is created in `action_required` at 0s and never starts. That is quiet in the worst way: `gh pr checks` reports "no checks reported", which reads as "this workflow does not apply here" rather than "this workflow is blocked". PR #51 (4.1.11 -> 4.2.6) sat like that and was only caught because somebody happened to look. Merging in that state loses everything build.yml has that the nightly does not already duplicate: the JDK 8 build, the pre-commit hook test, and the whole windows-bat job. So the `latest` job now finds that run and approves it. When the token cannot, the notice goes on the PR itself rather than into a warning annotation on an otherwise-green nightly, because that is the same kind of thing nobody reads. Separately, both CLAUDE.md and the README said Gudu's Maven repo keeps only the newest version and deletes the rest. Measured on 2026-08-24, it serves 4.1.9, 4.1.11 and 4.2.6 -- 200 for every .jar and .pom, and maven-metadata.xml lists exactly those three, so the metadata is pruned in step rather than left stale. 4.1.11 went on resolving after 4.2.6 was published on 2026-08-23. The five versions that did vanish on 2026-07-28 (4.1.4 through 4.1.8) are still 404 and are not coming back, but that was a deliberate recall, not routine cleanup after a release, and the README already documented it as such. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UK3dBXFXqiDRYJxz1YxWCr
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both found while landing #51 (the 4.1.11 → 4.2.6 bump).
The bump PR's build never actually runs
nightly.ymlopens the bump PR partly so that "the push-triggeredbuild.yml[gets] a chance to disagree". It does not get one.GitHub gates workflow runs from first-time contributors — this repository's policy is
first_time_contributors, read back from/actions/permissions/fork-pr-contributor-approval— andgithub-actions[bot]counts as one. So thepull_requestrun on a bump branch is created inaction_requiredat 0s and never starts.It is quiet in the worst way:
gh pr checksreports "no checks reported", which reads as this workflow does not apply here rather than this workflow is blocked. #51 sat like that until someone happened to look. Merging in that state loses every part ofbuild.ymlthe nightly does not already duplicate — the JDK 8 build, the pre-commit hook test, and the wholewindows-batjob.The
latestjob now finds that run and approves it. When the token cannot, the notice is posted on the PR itself rather than as a warning annotation on an otherwise-green nightly, since that is the same kind of thing nobody reads.All reachable paths were exercised by extracting the step's script and running it against the live API:
32689079075correctly,not gated, nothing to approve, exit 0The approve call itself has no gated run to test against, but it is the same
POST .../approvethat unblocked #51 by hand — with a personal token rather thanGITHUB_TOKEN, which is exactly why the fallback exists.The retention story was wrong
The README said
4.1.9was the only version left on the server. Measured 2026-08-24:.jar/.pommaven-metadata.xmllists exactly those three, so it is pruned in step with reality rather than left stale, and4.1.11went on resolving after4.2.6was published on 2026-08-23. The five that vanished on 2026-07-28 are still gone and are not coming back — but that was a deliberate recall, which the README already documents correctly. Only the "residue" sentence and the nightly section needed correcting.(The same correction was made to
CLAUDE.md, which is gitignored here, so it is not in this diff.)🤖 Generated with Claude Code
https://claude.ai/code/session_01UK3dBXFXqiDRYJxz1YxWCr