fix(prices): sync current interval display with Core - #64
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_9baba175-9f01-41e3-a87b-468ceb6879c8) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | f808dd8 | Commit Preview URL Branch Preview URL |
Sep 07 2026, 04:47 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The price chart used a one-hour window for NOW, so quarter-hour prices could show a past price. Tomorrow also labeled a future price as NOW.
Copy the corrected chart from Core commit fbd29b50781fbd7c11dd297cd3e9a3845c5b746f, with its provenance and recorded digest. The body is byte-identical to Core. NOW uses the interval that contains the current time; a future window or gap shows —. The wire still owns totals, and the fed chart makes no HTTP requests.
Paired Core change: srcfl/ftw#1102 (merged).
Validation: added wire-to-DOM regressions for the quarter boundary and Tomorrow; both reproduce the old output.
npm run verifypassed with 1,019 tests and one existing skipped test, zero type errors/warnings, and a production build. Contract and token checks pass against the paired Core checkout. The first full run hit the existing asynchronous Energy chart test; the targeted run and full rerun passed. Browser checks on the production build passed at desktop and 390 px mobile width with simulated data. Real encrypted pairing was not part of this test.Note
Low Risk
Display-only vendored chart sync with regression tests; no auth, protocol, or pricing calculation changes in the app layer.
Overview
Re-vendors
ftw-price-chart.jsfrom Core so the stats row’s now line matches the active price slots instead of assuming one-hour windows or picking the nearest slot.The chart now derives now via
buildPriceSummary, which only shows a value when wall-clock time falls inside a slot (including 15-minute intervals). Viewing Tomorrow or a window with no covering slot shows — instead of a misleading future or past price. The vendor digest and a patch changeset document the behavior; fed wire tests lock in the quarter-hour boundary and Tomorrow cases without HTTP fetches.Reviewed by Cursor Bugbot for commit f808dd8. Bugbot is set up for automated code reviews on this repo. Configure here.