chore: stop auto-requesting Erik as a reviewer - #1072
Merged
Conversation
Cursor's PR routing agent picks reviewers from commit history, so cursor[bot] has been requesting @erikarenhill on almost every agent PR. The GitHub Discord bot then pings him a few times a day. Request reviews only from CODEOWNERS for changed paths. He is not one. Humans can still request him when they actually need him. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
marked this pull request as ready for review
September 4, 2026 07:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Left a non-blocking comment; no reviewers assigned. Cursor Bugbot passed with no findings, but this PR introduces approval-policy and routing files that do not authorize auto-approval, so CODEOWNERS review is still required. The matching CODEOWNER is the PR author, so I did not add a review request.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted text proposal
Discord
#dev-core, 2026-09-04: Erik asked that the GitHub bot stop pinging him a few times a day. Pings should still work when a human actually wants his attention.What changed
Cursor's PR Routing agent (
cursor[bot]) has been requesting Erik — and often Johan — as reviewers on almost every agent PR, from commit history rather than CODEOWNERS. The GitHub Discord bot turns those review requests into pings, and it keeps doing it on later pushes whether or not anyone responds.This PR tells that agent, and coding agents, to request GitHub reviews only from CODEOWNERS for paths the PR actually changes:
APPROVAL_POLICY.md— Cursor's documented override for reviewer selection.cursor/approval-policies/ROUTING.md— points the router at that policyAGENTS.md/.github/CODEOWNERS— same rule for coding agents; Erik is not a CODEOWNERHumans can still request him by hand when it is something real.
Why
He is about to mute the repo. He was already removed as web CODEOWNER; the routing agent never noticed and kept picking him from git history.
Boundaries and safety
No runtime behaviour changes. CODEOWNERS review for drivers, Lua host, release/CI and agent rules is unchanged. Web/UI still needs a human looking at the rendered page; that is still not a GitHub review request.
Verification
cursor[bot], not CODEOWNERS (he is not in that file). Examples: feat(appproto): ops to set the car's charge level and PV-only #1069, feat(ev): boost from the home battery lives in the EV modal; legacy cover retired #1068, feat(ev): the schedule saves as you change it, with weekday chips #1067, feat(ev): show the plan at plug-in, set the car's charge level without a button #1062, fix(loadpoint): PV surplus adds to a scheduled charge once the home battery is above the threshold #1061.Draft PR #969 also edits
AGENTS.md(a Cloud Agent layout section at the bottom). This only adds a bullet in "Working alongside other people"; the hunks should not collide.No changeset: markdown-only, auto-exempt.