feat: to-be-checked and to-be-partially-checked implementation - #175
feat: to-be-checked and to-be-partially-checked implementation#175KeylaMunnoz wants to merge 3 commits into
Conversation
JDOM10
left a comment
JDOM10
left a comment
There was a problem hiding this comment.
Hey @KeylaMunnoz! This is looking great, just left a few comments. Let me know what do you think! 
| public toBeChecked(): this { | ||
| const isNativeCheckable = isCheckableInput(this.actual); | ||
| const isAriaCheckable = isValidAriaChecked(this.actual) | ||
| && ["true", "false"].includes(this.actual.getAttribute("aria-checked") ?? ""); |
There was a problem hiding this comment.
isValidAriaChecked already restricts to "true" | "false" | "mixed", so the ["true", "false"].includes(...) clause makes the helper call redundant — the second check fully covers it. Let's drop one of them (or fold the true/false-only logic into the helper) so the intent is clear.
There was a problem hiding this comment.
Good catch! I moved the "true"/"false" validation into a dedicated isValidAriaCheckedStrict helper.
The new helper explicitly excludes "mixed" for checked-only cases.
| public toBeChecked(): this { | ||
| const isNativeCheckable = isCheckableInput(this.actual); | ||
| const isAriaCheckable = isValidAriaChecked(this.actual) | ||
| && ["true", "false"].includes(this.actual.getAttribute("aria-checked") ?? ""); |
There was a problem hiding this comment.
Also this accepts any element with aria-checked, so a non-widget like would pass. Similar to how toBePressed gates on isButtonElement, we should require a checkable role (checkbox, radio, switch, …) here. Related: the aria-radio-* fixtures are currently unused, so radio-role coverage is missing too.
There was a problem hiding this comment.
Good catches! Both issues were addressed:
isValidAriaCheckedStrictnow validates both thearia-checkedvalue and a valid checkable ARIA role (checkbox,radio, orswitch). The JSDoc was updated accordingly.- Added test coverage for
role="radio"witharia-checked="true"and"false", plus a case ensuring elements without a valid checkable role are rejected.
2 participants
Implementation of both matchers: