chore(edge): refactoring and migration to new SDK structure - #1503
Open
GokceGK wants to merge 11 commits into
Open
chore(edge): refactoring and migration to new SDK structure#1503GokceGK wants to merge 11 commits into
GokceGK wants to merge 11 commits into
Conversation
relates to STACKITCLI-357
relates to STACKITCLI-357
rubenhoenle
requested changes
Jul 28, 2026
rubenhoenle
left a comment
rubenhoenle
left a comment
Member
There was a problem hiding this comment.
Just a first glance, this thing is big. Will have to take a second look but I have to quit work for today.
| return string(kubeconfigYAML), nil | ||
| default: | ||
| return "", fmt.Errorf("%w: %s", commonErr.NewNoIdentifierError(""), format) | ||
| return "", fmt.Errorf("format is not JSON or YAML: %s", format) |
Member
There was a problem hiding this comment.
can't we use p.OutputResult here?
Contributor
Author
There was a problem hiding this comment.
not really, here I am returning the marshalled data which can be written in a file or output depending on the given flags.
Contributor
There was a problem hiding this comment.
yeah if we wanted to use p.OutputResult here we would need to change the logic of outputResult
| // Output result based on the configured output format | ||
| func outputResult(p *print.Printer, outputFormat string, token *edge.Token) error { | ||
| if token == nil || token.Token == nil { | ||
| if token == nil { |
Member
There was a problem hiding this comment.
same as above, move this nil check into the callback for the pretty output
relates to STACKITCLI-357
relates to STACKITCLI-357
Merging this branch changes the coverage (11 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-357
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)