Skip to content

fix(sqlserverflex): fix instance create without --acl flag #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgoetz-inovex merged 1 commit into from
Aug 7, 2026
+33 −0
Merged

fix(sqlserverflex): fix instance create without --acl flag #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/cmd/beta/sqlserverflex/instance/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient sqlserverfle
return req, err
}

if model.ACL == nil {
model.ACL = make([]string, 0)
}

req = req.CreateInstancePayload(sqlserverflex.CreateInstancePayload{
Name: model.InstanceName,
Network: sqlserverflex.CreateInstancePayloadNetwork{
Expand Down
29 changes: 29 additions & 0 deletions internal/cmd/beta/sqlserverflex/instance/create/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,35 @@ func TestBuildRequest(t *testing.T) {
},
isValid: false,
},
{
description: "nil acl",
model: fixtureInputModel(
func(model *inputModel) {
model.ACL = nil
}),
listFlavorsResp: &sqlserverflex.ListFlavorsResponse{
Flavors: []sqlserverflex.ListFlavors{
{
Id: testFlavorId,
Cpu: int64(2),
Memory: int64(4),
},
},
},
listStoragesResp: &sqlserverflex.ListStoragesResponse{
StorageClasses: []sqlserverflex.FlavorStorageClassesStorageClass{{
Class: "storage-class",
}},
StorageRange: sqlserverflex.FlavorStorageRange{
Min: 10,
Max: 100,
},
},
isValid: true,
expectedRequest: testClient.DefaultAPI.CreateInstance(testCtx, testProjectId, testRegion).CreateInstancePayload(fixturePayload(func(payload *sqlserverflex.CreateInstancePayload) {
payload.Network.Acl = make([]string, 0)
})),
},
}

for _, tt := range tests {
Expand Down
Loading