Skip to content

starknet_os_flow_tests,starknet_os,starknet_transaction_prover: test the Cairo digest via verifier - #15095

Closed
einat-starkware wants to merge 1 commit into
claude/privacy-proof-os-verify-gsxf2h-5-verifier-taskfrom
claude/privacy-proof-os-verify-gsxf2h-6-combined-verify
Closed

einat-starkware wants to merge 1 commit into
claude/privacy-proof-os-verify-gsxf2h-5-verifier-taskfrom
claude/privacy-proof-os-verify-gsxf2h-6-combined-verify

Conversation

@einat-starkware

@einat-starkware einat-starkware commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Part 5 of the single-proof verification stack; last PR of milestone 1. Extracts the Cairo digest entry-point runner (starknet_os::test_utils::proof_fact_fold_runner) and the verifier-task fixtures (starknet_transaction_prover::verifier_task::test_utils) into shared test utilities, and adds the combined test:

  • test_cairo_processed_proof_digest_matches_circuit_verifier_output: the Cairo0 processed-proof output digest over the fixture's proof facts satisfies the real circuit verifier's output comparison.

The OS-in-the-loop test (test_os_emitted_output_feeds_verifier_task_comparison) moved to #15064, since it needs the digest in the OS output.

Stack (restructured):

🤖 Generated with Claude Code

https://claude.ai/code/session_01E43QxCycT6DpDJo435Ft8R

@cursor

cursor Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactors and a new integration test; production verifier/OS paths are unchanged aside from exposing test_utils under the testing feature.

Overview
Extracts shared test helpers for proof-fact Cairo digest checks and circuit-verifier fixtures, then adds an end-to-end flow test that ties them together.

Cairo0 digest assertions move from proof_fact_fold_test.rs into starknet_os::test_utils::proof_fact_fold_runner, and verifier gzip fixtures / run_one_leaf_verifier_task move into starknet_transaction_prover::verifier_task::test_utils behind a new testing feature (optional flate2). starknet_os’s testing feature also pulls in apollo_starknet_os_program/test_programs.

test_cairo_processed_proof_digest_matches_circuit_verifier_output in starknet_os_flow_tests runs the real one-leaf circuit verifier on the shared fixture, checks leaf/combined digests against Cairo entry points, and asserts verify_circuit_verifier_task_output accepts the processed-proof output digest.

Reviewed by Cursor Bugbot for commit 831c9df. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from c9f1861 to fcf4042 Compare September 17, 2026 13:36
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 69d4399 to 5038791 Compare September 17, 2026 13:36
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from fcf4042 to 377b5b4 Compare September 22, 2026 09:22
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 5038791 to a47dcf4 Compare September 22, 2026 09:22
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 377b5b4 to 78719ea Compare September 23, 2026 09:17
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from a47dcf4 to 8de8660 Compare September 23, 2026 09:17
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 78719ea to 715f6db Compare September 23, 2026 12:59
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 8de8660 to 3e16a65 Compare September 23, 2026 12:59
@einat-starkware einat-starkware changed the title starknet_os_flow_tests,starknet_os,starknet_transaction_prover: test the fold against the verifier starknet_os_flow_tests,starknet_os,starknet_transaction_prover: test the single proof against the verifier Sep 23, 2026
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 715f6db to f99428f Compare September 23, 2026 14:56
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 3e16a65 to 84066c8 Compare September 23, 2026 14:56
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from f99428f to 85939ce Compare September 24, 2026 08:11
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 84066c8 to 9072cff Compare September 24, 2026 08:11
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 85939ce to 0d3dd94 Compare September 24, 2026 08:15
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 9072cff to b498496 Compare September 24, 2026 08:15
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 0d3dd94 to 44b22ee Compare September 24, 2026 13:28
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from b498496 to 704010f Compare September 24, 2026 13:28
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from 44b22ee to cdf7d20 Compare September 24, 2026 17:20
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 704010f to 9d67fe2 Compare September 24, 2026 17:20
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from cdf7d20 to cd0a0ba Compare September 28, 2026 08:01
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 9d67fe2 to 5d45202 Compare September 28, 2026 08:01
@einat-starkware
einat-starkware added this pull request to stack #15156 September 28, 2026 08:17
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from cd0a0ba to d4a5279 Compare September 28, 2026 10:51
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 5d45202 to 52dd336 Compare September 28, 2026 10:51
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from d4a5279 to 0108b56 Compare September 30, 2026 10:47
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 52dd336 to 7b2ddc6 Compare September 30, 2026 10:47
@einat-starkware einat-starkware changed the title starknet_os_flow_tests,starknet_os,starknet_transaction_prover: test the single proof against the verifier starknet_os_flow_tests,starknet_os,starknet_transaction_prover: test the Cairo digest via verifier Sep 30, 2026
@einat-starkware
einat-starkware removed this pull request from stack #15156 September 30, 2026 10:51
@einat-starkware
einat-starkware added this pull request to stack #15158 September 30, 2026 10:53
…the Cairo digest via verifier

Extracts the Cairo digest entry-point runner and the verifier-task
fixtures into shared test utilities, and adds the combined test: the
Cairo0 processed-proof output digest over the fixture's proof facts
satisfies the real circuit verifier's output comparison.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E43QxCycT6DpDJo435Ft8R
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-6-combined-verify branch from 8299618 to 831c9df Compare September 30, 2026 15:46
@einat-starkware
einat-starkware force-pushed the claude/privacy-proof-os-verify-gsxf2h-5-verifier-task branch from ec69402 to 32effb4 Compare September 30, 2026 15:46
@einat-starkware
einat-starkware removed this pull request from stack #15158 October 1, 2026 08:23

Copy link
Copy Markdown
Contributor Author

Closing: the stack now runs the circuit verifier in Cairo, from the aggregator (#15161, #15163, #15162), instead of as a Rust bootloader task, so this test of the Rust task is no longer needed.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants