Skip to content

💱 Trading Terms in Glossary - #2745

Open
JFWooten4 wants to merge 3 commits into
stellar:mainfrom
JFWooten4:glossary-trading
Open

💱 Trading Terms in Glossary#2745
JFWooten4 wants to merge 3 commits into
stellar:mainfrom
JFWooten4:glossary-trading

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

Atomic swaps are a foundational concept for blockchain exchange. There has been some recent chatter about routers using non-atomic transactions. New readers should receive a point of reference for atomicity separate from transaction execution.

Also, SPEEDEX is a substantial network-specific research project. It's too nascent for its own page at this point, but it should be mentioned somewhere in the docs. This is the lowest point of friction to start.

Copilot AI balanced review requested due to automatic review settings August 13, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds trading terminology to the glossary.

Changes:

  • Defines atomic swaps with related documentation.
  • Introduces SPEEDEX with research and proposal references.

Recommendation: NEEDS-CHANGES — remove the extraneous “default” wording.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/learn/glossary.mdx

A decentralized method of exchanging one asset for another without the need for a trusted third-party intermediary. Atomic swaps allow the interchange to either complete fully for both parties or not at all, hence the term "atomic," meaning indivisible. If one party fails to fulfill the required conditions, the trade is automatically canceled and both parties retain their assets.

Learn more in the default [Liquidity on Stellar section](./fundamentals/liquidity-on-stellar-sdex-liquidity-pools.mdx) or an [Atomic Swap example contract](../build/smart-contracts/example-contracts/atomic-swap.mdx).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a heavy judgment call. While it wasn't in my original draft, it surfaced through comparison with the protocol's default atomic transaction execution. In a sentence comparing it to the DEX with a Soroban example, I believe it fits.

Namely, every asset always uses the DEX. Anyone can create a transaction for protocol liquidity using native operations. Comparatively, every smart contract requires at least overhead for initialization and (in practice) substantial differentiating networking to function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants