Document Env::upload and v28 code entries - #2764
Draft
leighmcculloch wants to merge 2 commits into
Draft
Conversation
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Document the new
Env::upload/Env::upload_attestutils and the SDK v28 change where each natively registered contract now gets its own contract code entry instead of sharing one.Why
rs-soroban-sdk PR #2007 stopped sharing a single contract code entry across all natively registered test contracts, which changes committed test snapshot hashes and breaks any test relying on the old shared-entry behavior, with no prior docs explaining the change or how to opt back into a shared entry via the new upload testutils.