Skip to content

Don't inspect containers with the dead status - #407

Merged
stepchowfun merged 2 commits into
stepchowfun:mainfrom
firecow:skip-dead-containers
Sep 1, 2026
Merged

Don't inspect containers with the dead status#407
stepchowfun merged 2 commits into
stepchowfun:mainfrom
firecow:skip-dead-containers

Conversation

@firecow

@firecow firecow commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

A container stuck in the dead status makes docker container inspect fail, and since a failed chunk is fatal in image_ids_in_use, docuum never gets past its initial vacuum and retries every five seconds forever. This is #237 and #341 with a different status, so dead is now excluded from the listing the way removing already is.

On the affected host the dead container could not be removed, and dropping it from the listing takes the inspect call from exit 1 to exit 0.

@stepchowfun stepchowfun left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! Small comment but looking good overall

Comment thread src/run.rs Outdated

@stepchowfun stepchowfun left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stepchowfun
stepchowfun merged commit ac97de9 into stepchowfun:main Sep 1, 2026
6 checks passed
@stepchowfun

Copy link
Copy Markdown
Owner

Released in v0.27.1 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants