Feature/cap image dimensions - #192
Merged
Merged
Conversation
Shrink oversized images to a max edge (1568px, matching Anthropic's server-side limit) once, where they enter a conversation, so the bounded version is stored and re-sent without repeated resize work as history grows. - add shared tools_core::cap_base64_image + MAX_IMAGE_EDGE (next to ImageData, reachable by mcp_client which does not depend on llm) - cap user attachments (content.rs) and ACP prompt images - cap tool sources: browser screenshot capture, view_images load, MCP output
Move image capping into a Render::cap_images hook (default no-op, overridden by browser/view_images/MCP outputs) invoked by DynTool at two points: - on creation (invoke), replacing the earlier per-tool inline capping - on deserialize_output, so sessions persisted before capping (or by an older version) get oversized tool-result images corrected on load instead of being unresumable when a provider rejects an >8000px image Also cap oversized user-attached images in the conversation tree when a chat session is loaded from disk (load_chat_session).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.