Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
adthrasher
changed the title
adthrasher
previously approved these changes
Aug 19, 2026
| outputs: | ||
| sampled_bam: | ||
| Defined: true | ||
| - Defined: true |
Member
There was a problem hiding this comment.
Have these been quietly broken or did something change in sprocket?
Member
Author
There was a problem hiding this comment.
they've been silently broken I believe. Alex has done some recent work on improving the diagnostics emitted from broken test definitions. I think the initial implementation WARNed about them, but they were easy to miss in the giant stream of logs. Alex made them errors semi-recently.
cc @Serial-ATA
a-frantz
marked this pull request as ready for review
August 19, 2026 15:05
adthrasher
added a commit
that referenced
this pull request
Aug 19, 2026
Adds spellcheck to the CI. Some of the changes duplicate those in #328. Before submitting this PR, please make sure: - [ ] You have added a few sentences describing the PR here. - [ ] The code passes all CI tests without any errors or warnings. - [ ] You have added tests (when appropriate). - [ ] You have added an entry in any relevant CHANGELOGs (when appropriate). - [ ] If you have made any changes to the `scripts/` or `docker/` directories, please ensure any image versions have been incremented accordingly! - [ ] You have updated the README or other documentation to account for these changes (when appropriate).
adthrasher
reviewed
Aug 19, 2026
driveby typo and test definition fixes
adthrasher
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We attempted and reverted using non-empty qualifies on arrays in an earlier PR (#240) due to friction caused by Sprocket analysis and odd type coercion. That was solved a long time ago and now that friction is gone. It was trivial to make this type update, which was a very pleasant surprise.
also includes drive-by typo and test definition fixes
Describe the problem or feature in addition to a link to the issues.
Before submitting this PR, please make sure:
scripts/ordocker/directories, please ensure any image versions have been incremented accordingly!