Skip to content

Fix a pylint disable comment - #1205

Merged
vojtechtrefny merged 1 commit into
storaged-project:masterfrom
vojtechtrefny:master_pylint-disable-fix
Aug 26, 2026
Merged

Fix a pylint disable comment#1205
vojtechtrefny merged 1 commit into
storaged-project:masterfrom
vojtechtrefny:master_pylint-disable-fix

Conversation

@vojtechtrefny

@vojtechtrefny vojtechtrefny commented Aug 25, 2026

Copy link
Copy Markdown
Member

This stopped working with pylint 4.0.7 which is probably a pylint regression, but the correct location for the comment is always on the same line where the error occurs (disable-next can be used to supress the warning on the following like) so this worked only by acciddent anyway.

Summary by CodeRabbit

  • Style
    • Clarified exception-handler formatting while preserving existing behavior.

This stopped working with pylint 4.0.7 which is probably a pylint
regression, but the correct location for the comment is always
on the same line where the error occurs (disable-next can be used
to supress the warning on the following like) so this worked only
by acciddent anyway.
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 929b9957-541f-48d5-b7b8-d2b9ca7babb7

📥 Commits

Reviewing files that changed from the base of the PR and between 31f2a3f and be0a2a7.

📒 Files selected for processing (1)
  • src/python/gi/overrides/BlockDev.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The ErrorProxy exception handler moves the catching-non-exception pylint suppression onto the except clause. Exception matching and transformation behavior remain unchanged.

Changes

ErrorProxy lint suppression

Layer / File(s) Summary
Attach pylint suppression to exception handler
src/python/gi/overrides/BlockDev.py
The pylint suppression moves from a preceding comment to the except clause. Exception behavior remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to be0a2

This is a narrowly scoped fix to the placement of a lint-disable comment, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change: updating a Pylint disable comment location.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vojtechtrefny
vojtechtrefny merged commit 49f2be9 into storaged-project:master Aug 26, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants