Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- dependencies: python python3-build twine
task: make -f Makefile package
runs-on: ubuntu-latest
container: fedora:43 # CURRENT DEVELOPMENT ENVIRONMENT
container: fedora:44 # CURRENT DEVELOPMENT ENVIRONMENT
steps:
- uses: actions/checkout@v6
with:
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
python3-hypothesis
task: PYTHONPATH=./src make -f Makefile test
runs-on: ubuntu-latest
container: fedora:43 # CURRENT DEVELOPMENT ENVIRONMENT
container: fedora:44 # CURRENT DEVELOPMENT ENVIRONMENT
steps:
- name: Install python3.12
run: >
Expand Down Expand Up @@ -103,4 +103,4 @@ jobs:
general_checks:
uses: stratis-storage/github-actions/.github/workflows/reusable_general.yml@master
with:
fedora-container-image-number: 43 # CURRENT DEVELOPMENT ENVIRONMENT
fedora-container-image-number: 44 # CURRENT DEVELOPMENT ENVIRONMENT
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ test:

.PHONY: coverage
coverage:
coverage --version
coverage run --timid --branch -m unittest discover tests
coverage report -m --fail-under=100 --show-missing --include="./src/*"
python3 -m coverage --version
python3 -m coverage run --timid --branch -m unittest discover tests
python3 -m coverage report -m --fail-under=100 --show-missing --include="./src/*"

.PHONY: fmt
fmt:
Expand Down
1 change: 1 addition & 0 deletions src/into_dbus_python/_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"""
Error hierarchy for xformer generator.
"""

# isort: STDLIB
from typing import Any, Union

Expand Down
6 changes: 3 additions & 3 deletions src/into_dbus_python/_xformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ def the_func(a_tuple, *, variant=0):
:rtype: object
"""
try:
(signature, an_obj) = a_tuple
(func, sig) = self.COMPLETE.parseString(signature)[0]
signature, an_obj = a_tuple
func, sig = self.COMPLETE.parseString(signature)[0]
# Allow KeyboardInterrupt error to be propagated
except KeyboardInterrupt as err: # pragma: no cover
raise err
Expand Down Expand Up @@ -147,7 +147,7 @@ def the_dict_func(a_dict, *, variant=0):
return (the_dict_func, "a{" + signature + "}")

if len(toks) == 2:
(func, sig) = toks[1]
func, sig = toks[1]

def the_array_func(a_list: Sequence[Any], *, variant=0):
"""
Expand Down
8 changes: 4 additions & 4 deletions tests/test_hypothesis.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def test_empty_dict(self, strat):
"""
Test parsing an empty dict with a valid signature.
"""
(key_sig, value_sig) = strat
key_sig, value_sig = strat
sig = f"{key_sig}{value_sig}"
self.assertEqual(signature(dbus.Dictionary(signature=sig)), "a{" + sig + "}")

Expand All @@ -197,9 +197,9 @@ def test_parsing(self, strat):
Verify that the variant levels always descend within the constructed
value.
"""
(a_signature, base_type_object) = strat
a_signature, base_type_object = strat

(func, sig_synth) = xformers(a_signature)[0]
func, sig_synth = xformers(a_signature)[0]
value = func(base_type_object)
sig_orig = dbus.Signature(a_signature)

Expand All @@ -224,7 +224,7 @@ def test_struct(self, strat):
Test exception throwing on a struct signature when number of items
is not equal to number of complete types in struct signature.
"""
(sig, struct) = strat
sig, struct = strat

xform = xformer(sig)

Expand Down