Skip to content

refactor(plugins): drop unused sherpa-onnx wave FFI bindings - #684

Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820652-drop-dead-wave-ffi
Closed

staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820652-drop-dead-wave-ffi

Conversation

@staging-devin-ai-integration

@staging-devin-ai-integration staging-devin-ai-integration Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Delete the SherpaOnnxWave struct and the SherpaOnnxReadWave / SherpaOnnxFreeWave externs from the sensevoice plugin's FFI module. They had no callers and were retained only by "kept for future use" comments plus #[allow(dead_code)]; the plugin receives decoded f32 frames and never reads wave files.
  • Shrinks the unsafe FFI surface a reader has to reason about. No behavior change.
  • The unused #[repr(C)] per-model config structs are intentionally left alone — they are required for SherpaOnnxOfflineModelConfig's ABI layout.

Review & Validation

  • Confirm nothing outside the plugin referenced the removed symbols (cargo clippy --all-targets in plugins/native/sensevoice passes clean).

Link to Devin session: https://staging.itsdev.in/sessions/b70e5ce2bbc7403ca8f026cf2b1d820b
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/b70e5ce2bbc7403ca8f026cf2b1d820b?variant=devin-insiders
Requested by: @streamer45


Devin Review

Status Commit
🟢 Reviewed 53f57fa

Devin Review (Staging)

Signed-off-by: streamkit-devin <devin@streamkit.dev>
@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration staging-devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review (Staging)

Debug

Playground

@streamer45 streamer45 closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants