refactor(plugins): drop unused sherpa-onnx wave FFI bindings - #684
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Signed-off-by: streamkit-devin <devin@streamkit.dev>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SherpaOnnxWavestruct and theSherpaOnnxReadWave/SherpaOnnxFreeWaveexterns from the sensevoice plugin's FFI module. They had no callers and were retained only by "kept for future use" comments plus#[allow(dead_code)]; the plugin receives decoded f32 frames and never reads wave files.#[repr(C)]per-model config structs are intentionally left alone — they are required forSherpaOnnxOfflineModelConfig's ABI layout.Review & Validation
cargo clippy --all-targetsinplugins/native/sensevoicepasses clean).Link to Devin session: https://staging.itsdev.in/sessions/b70e5ce2bbc7403ca8f026cf2b1d820b
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/b70e5ce2bbc7403ca8f026cf2b1d820b?variant=devin-insiders
Requested by: @streamer45
Devin Review
53f57fa