Skip to content

refactor(client): drop unread total_success snapshot field - #686

Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820784-drop-total-success
Closed

staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820784-drop-total-success

Conversation

@staging-devin-ai-integration

@staging-devin-ai-integration staging-devin-ai-integration Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • MetricsSnapshot.total_success had no reader — it was kept alive only by a rationale-free #[allow(dead_code)], which silently disabled dead-code checking for the whole struct.
  • Dropped the field; the derived values operators actually see (total_failures, success_rate) are still computed from the same local counter in get_snapshot, so printed output is unchanged.

Review & Validation

  • Confirm nothing outside apps/skit-cli/src/load_test/ consumed the field (repo-wide grep shows only in-module construction).
  • cargo clippy -p streamkit-client --all-targets and cargo test -p streamkit-client pass locally.

Link to Devin session: https://staging.itsdev.in/sessions/2345b1cb7fee4f8491cf0f5659aac0ab
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/2345b1cb7fee4f8491cf0f5659aac0ab?variant=devin-insiders
Requested by: @streamer45


Devin Review

Status Commit
🟢 Reviewed 261d1d5

Devin Review (Staging)

Signed-off-by: streamkit-devin <devin@streamkit.dev>
@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration staging-devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review (Staging)

Debug

Playground

@streamer45 streamer45 closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants