refactor(client): drop unread total_success snapshot field - #686
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Signed-off-by: streamkit-devin <devin@streamkit.dev>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricsSnapshot.total_successhad no reader — it was kept alive only by a rationale-free#[allow(dead_code)], which silently disabled dead-code checking for the whole struct.total_failures,success_rate) are still computed from the same local counter inget_snapshot, so printed output is unchanged.Review & Validation
apps/skit-cli/src/load_test/consumed the field (repo-wide grep shows only in-module construction).cargo clippy -p streamkit-client --all-targetsandcargo test -p streamkit-clientpass locally.Link to Devin session: https://staging.itsdev.in/sessions/2345b1cb7fee4f8491cf0f5659aac0ab
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/2345b1cb7fee4f8491cf0f5659aac0ab?variant=devin-insiders
Requested by: @streamer45
Devin Review
261d1d5