refactor(nodes): drop stale allow(unused_variables) in blit - #688
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Signed-off-by: streamkit-devin <devin@streamkit.dev>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 85.26% 85.28% +0.01%
==========================================
Files 251 251
Lines 76246 76246
Branches 2485 2485
==========================================
+ Hits 65014 65027 +13
+ Misses 11226 11213 -13
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scale_blit_rgba'ssrc_opaqueparameter carried#[allow(unused_variables)], but the parameter drives the opaque fast-path in the identity-blit closure. The attribute was inert, misleading, and would hide a real regression if that branch were ever removed.Review & Validation
cargo clippy -p streamkit-nodes --all-targets -- -D warnings(passes locally)Link to Devin session: https://staging.itsdev.in/sessions/f413553960d340f1961d386bce990b7a
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/f413553960d340f1961d386bce990b7a?variant=devin-insiders
Requested by: @streamer45
Devin Review
e6dc2b5