Skip to content

refactor(server): use MoQ route session_id in gateway logs - #689

Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820845-moq-route-session-id
Closed

staging-devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789820845-moq-route-session-id

Conversation

@staging-devin-ai-integration

@staging-devin-ai-integration staging-devin-ai-integration Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Route.session_id in the MoQ gateway was only kept alive by a rationale-free #[allow(dead_code)] (its sole reader was a #[cfg(test)] helper), making it look like route-ownership metadata the gateway could act on.
  • Instead of deleting it, the owning session id is now emitted where it has diagnostic value: connection accept/reject/failure traces and route unregistration. Multi-session gateways can now correlate a WebTransport path with the session that owns it from logs alone.
  • No behavior change — routing still matches purely on path; only tracing fields were added, and the suppression is gone.

Review & Validation

  • Confirm the extra session_id tracing fields are appropriate for these log lines (no sensitive content — session ids are already logged at registration).
  • cargo clippy -p streamkit-server --all-targets --features moq -- -D warnings and cargo test -p streamkit-server --features moq moq_gateway pass locally.

Link to Devin session: https://staging.itsdev.in/sessions/eb3b6634dd234926848d65f17db263bd
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/eb3b6634dd234926848d65f17db263bd?variant=devin-insiders
Requested by: @streamer45


Devin Review

Status Commit
🟢 Reviewed 9a5d053

Devin Review (Staging)

Drops the rationale-free #[allow(dead_code)] by emitting the owning session id in connection routing and route unregistration traces.

Signed-off-by: streamkit-devin <devin@streamkit.dev>
@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration staging-devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review (Staging)

Debug

Playground

@streamer45 streamer45 closed this Sep 19, 2026
@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.28%. Comparing base (64dcfda) to head (9a5d053).

Files with missing lines Patch % Lines
apps/skit/src/moq_gateway.rs 0.00% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   85.26%   85.28%   +0.01%     
==========================================
  Files         251      251              
  Lines       76246    76246              
  Branches     2485     2485              
==========================================
+ Hits        65014    65028      +14     
+ Misses      11226    11212      -14     
  Partials        6        6              
Flag Coverage Δ
backend 85.37% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 85.79% <ø> (ø)
engine 83.76% <ø> (ø)
api 91.14% <ø> (ø)
nodes 85.00% <ø> (+0.04%) ⬆️
server 85.26% <0.00%> (ø)
plugin-native 84.79% <ø> (ø)
plugin-wasm 95.41% <ø> (ø)
ui-services 86.29% <ø> (ø)
ui-components 68.94% <ø> (ø)
Files with missing lines Coverage Δ
apps/skit/src/moq_gateway.rs 51.88% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants