refactor(server): use MoQ route session_id in gateway logs - #689
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit into
staging-devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Drops the rationale-free #[allow(dead_code)] by emitting the owning session id in connection routing and route unregistration traces. Signed-off-by: streamkit-devin <devin@streamkit.dev>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 85.26% 85.28% +0.01%
==========================================
Files 251 251
Lines 76246 76246
Branches 2485 2485
==========================================
+ Hits 65014 65028 +14
+ Misses 11226 11212 -14
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route.session_idin the MoQ gateway was only kept alive by a rationale-free#[allow(dead_code)](its sole reader was a#[cfg(test)]helper), making it look like route-ownership metadata the gateway could act on.Review & Validation
session_idtracing fields are appropriate for these log lines (no sensitive content — session ids are already logged at registration).cargo clippy -p streamkit-server --all-targets --features moq -- -D warningsandcargo test -p streamkit-server --features moq moq_gatewaypass locally.Link to Devin session: https://staging.itsdev.in/sessions/eb3b6634dd234926848d65f17db263bd
Open in Devin Desktop: https://staging.itsdev.in/desktop/session/eb3b6634dd234926848d65f17db263bd?variant=devin-insiders
Requested by: @streamer45
Devin Review
9a5d053