fix(realtime): properly dispose of stale MQTT clients before reconnect - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the management of MQTT client connections in the
MiniBrewRealtimeManagerto prevent resource leaks and ensure clean disconnects, especially during reconnects and error scenarios. It introduces a helper method for disposing of MQTT clients, updates the reconnect and disconnect logic to use this helper, and adds a test to verify the correct behavior.MQTT client management improvements:
_dispose_mqtt_clienthelper method torealtime.pyto handle safe disconnection and cleanup of MQTT clients, preventing stale sockets and threads._async_do_connect,_handle_disconnected, andasync_stopmethods to use_dispose_mqtt_clientfor consistent cleanup during reconnection attempts, disconnect events, and shutdown. [1] [2] [3] [4]Testing enhancements:
test_realtime_manager_disconnects_stale_client_before_reconnectto ensure that any existing MQTT client is properly disconnected before a new connection is established.