Hannah/add 4dp availability price to schema - #35
Open
hannahouazzane wants to merge 2 commits into
Open
Conversation
johnjoey
reviewed
Aug 26, 2026
Contributor
There was a problem hiding this comment.
I'd guess the channel api will also have this new field, so we should add it the the channel.yml schema too. It's only the api.yml file that is actually used to gen the model classes, but the other yml files are used to generate the docs.
Also, did we use the /generate.php script to gen the models, or did we manually update the models? Will want to use the script if latter.
johnjoey
requested changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the weekly pricing to 4dp to the API schema