Repository navigation
feat: land the post-v1.6 upstream sync with v1.6.1 corrections - #275
Conversation
Graph semantics (extraction version 13): generator callables, TypeScript interface members, nested declarator handlers, CommonJS exports, React handler hooks and curried wrappers; C++ constructor calls, pure virtual methods, raw strings and designated-initializer macros; Scala multi-parameter lists, mixins and companion objects; Dart extension types; method values passed as callbacks as function references. Resolution safety: cross-file visibility for C statics, private JVM/Swift/ Scala/Dart/PHP definitions, Go package-locals and Rust module-private items; no receiver guesses for call results, bare JS calls, receiver-less Go calls, unproven this.field or awaited receivers; Rust self.method() bound to its impl owner; sealed JS modules; function-like C/C++ macros and aggregates never fabricate calls. Gates follow upstream's v1.6.1 final forms and read per-file source facts built once per resolution pass. CLI/MCP/installer/lifecycle: callers/callees/impact grouped by definition, line-numbered node selectors, committed pending changes in status, unsupported-only and extensionless-path honesty, parse-collapse warnings, live-synced explicit projectPath projects, a kernel writer lock, atomic edge rebinding, explicit child-index safety, profile-directory, OpenCode 2 and Explore-loading installer support, and prompt-hook bounds.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (93.34%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 95.34% 95.22% -0.12%
==========================================
Files 145 151 +6
Lines 85751 91465 +5714
==========================================
+ Hits 81761 87100 +5339
- Misses 3990 4365 +375
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d891dc3ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A failed transport attach does not grant a second watcher. Keep the | ||
| // request path available as a read-only direct session while the live | ||
| // daemon retains the sole background-writer capability. | ||
| serve_direct_stdio(project, explicit_project_services(no_watch)) |
There was a problem hiding this comment.
When daemon_already_running is fooled by a reused PID, or the recorded daemon has a missing socket or incompatible hello, proxy_to_running_daemon returns None and this branch now starts a permanently read-only session without catch-up or a watcher. The previous fallback called serve_direct, so this change silently leaves the session serving a stale graph; attempt writer ownership and start direct services when no daemon actually owns them, or fail instead of silently disabling synchronization.
AGENTS.md reference: AGENTS.md:L56-L58
Useful? React with 👍 / 👎.
| let source: &str = &self.source; | ||
| LocalBindingSites { | ||
| var_decls: keyword_sites(source, &["const", "let", "var"]), | ||
| fn_decls: keyword_sites(source, &["function", "class"]), | ||
| arrows: source.match_indices("=>").map(|(at, _)| at).collect(), |
There was a problem hiding this comment.
Because binding sites are collected from raw source, text such as // const run = mock or a string containing function run is treated as a real local binding. When the file later calls an imported/cross-file run(), is_locally_bound_js_name filters out the valid target and leaves the call unresolved; derive these offsets from the comment/string-blanked view instead.
Useful? React with 👍 / 👎.
| let line = facts.raw_line(index).unwrap_or(""); | ||
| if impl_header.is_match(line) { | ||
| let code = line.split_once("//").map_or(line, |(code, _)| code); | ||
| return for_clause.is_match(code); |
There was a problem hiding this comment.
for
For a normally formatted multiline trait impl such as impl<T> followed by Trait for Type<T>, the upward scan reaches the impl line and immediately tests only that line for for. It therefore classifies the trait method as an ordinary private inherent method, and calls from outside the defining module are rejected by the new cross-file visibility gate. Join the impl header through its opening brace, or inspect the syntax tree, before deciding whether it is a trait impl.
Useful? React with 👍 / 👎.
| > **Kiro global versus project-local.** A global Kiro install writes a bare | ||
| > `serve --mcp` entry with no `--path`. It can list tools and query any existing | ||
| > index when the agent supplies `projectPath` per call, but it does not own a | ||
| > project's live watcher. Run `codegraph init --target=kiro <project>` (or a | ||
| > local Kiro install from that project) to write a project-level entry with an | ||
| > absolute `--path` and enable live catch-up/watch. Kiro does not expand |
There was a problem hiding this comment.
This read-only claim is false after this commit: every non-opted-out MCP process installs explicit_project_services, and an explicit projectPath calls ProjectServiceBroker::ensure, which starts or attaches the project's daemon and performs catch-up. Global Kiro users can therefore trigger a watcher without a local install, contrary to both this canonical documentation and the installer notes; update those claims or explicitly disable the broker for this target.
AGENTS.md reference: docs/AGENTS.md:L5-L8
Useful? React with 👍 / 👎.
| `pure_virtual.cpp`, `raw_string.cpp`, `designated_macro.c`, | ||
| `template_method.cpp`, `templated_call.cpp`, `ue_actor.h`, `union_agg.c`, | ||
| `union_agg.cpp`, `union_agg.mm` — 19 files). The inheritance base | ||
| `union_agg.cpp`, `union_agg.mm` — 23 files). The inheritance base |
There was a problem hiding this comment.
The newly updated 23 files assertion is not derived or checked by scripts/docs-check.py or a product test, so the next corpus addition can leave this canonical regeneration guide stale while all validation still passes. Either remove the count or add a source-contract check that derives it; the same issue applies to the newly changed TypeScript count below.
AGENTS.md reference: docs/AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Windows LockFileEx locks are mandatory, so reading the holder's pid/mode record from inside the kernel-locked writer.pid failed for every other handle and the contention message could not name the owner. Publish the record in a sibling writer.json (atomic rename) that is trusted only while the lock is held; writer.pid itself is never written.
19ca839 to
9600281
Compare
Git exports GIT_DIR and the other repository-locating variables to hooks. The committed-pending status test inherited them from pre-push and committed its throwaway fixture into the branch being pushed. The test now strips the variables for every git child, and the pre-push hook clears them before running the gate.
1 participant
Summary
Second of two PRs landing the 2026-09-15 upstream sync (colby
3ed73bcaudit) — the product changes on top of the engineering baseline in #271. Several ports were re-checked against the final forms upstream shipped in v1.6.1 (2026-09-29) and now follow them. Tracked upstream parity staysv1.6.0in this PR; the v1.6.1 alignment continues in follow-up PRs and is closed inUPSTREAM.mdonly after a release.Per-item evidence is in
docs/upstream-sync/POST_V1_6_MAIN_2026-09-15.md→ Implementation status.Graph semantics — extraction version 12 → 13
useCallback/useEffectEventand curried wrappers (#1741 #1638 #1669 #1675 #1747).=0.26.2, multi-parameter lists and mixins; companion objects are modules, never inheritance targets, and own their methods (#1823 #1824). Dart 3 extension types (#1784).ReferenceswithfnRef(#1820), never fabricatedCalls.Resolution safety (upstream v1.6.1 forms)
requireconstants are rejected.this.fieldneeds a declared type (#1496), awaited receivers follow the #1885 inference (#1840); typed method lookup matches within a language family, so.tsxreaches.ts.self.method()binds to the impl owner and declines ambiguous same-named owners (#1861/#1882). Fuzzy matching judges its single survivor and keeps closures unreachable, while C/C++ nesting stays reachable (#1708).CLI, MCP, installer, lifecycle
callers/callees/impactgrouped by definition with truncation metadata (#1512 #1639 #1674);node file:42,:a-b,#L42-L80(#1831); committed pending changes instatus(#1829); unsupported-only and extensionless-path honesty (#1502 #1830); collapsed-parse warning (#1522).projectPathprojects are live-synced through the shared daemon and re-attached if the daemon exits or the index is re-created (#1835); one kernel-locked long-lived writer per project (#1740); atomic edge rebinding (#1833/#1849); explicit childindexrefuses an initialized ancestor (#1524).CLAUDE_CONFIG_DIR/CODEX_HOME(#1627), native OpenCode 2 entries (#1698), Explore kept loaded (#1696); prompt hook capped at 9,000 bytes and skipping task-notification envelopes (#1694 #1832).Resolution performance
A post-audit review found the new gates rescanned whole files per reference. Per-file source facts are now built once per resolution pass.
initof generated single-file corpora (5,000 references each; one run, same host):this.field+ awaited receiversVerification
env -u RUSTUP_TOOLCHAIN make pre-ci: all checks passed; 3,704 tests, 0 failed; archive smokecodegraph 0.50.3.cargo audit --no-yanked: no vulnerabilities.BEGIN_COMMIT_OVERRIDE
feat(extract): index generator callables, TypeScript interface members, nested handlers, CommonJS exports and React handler hooks
feat(extract): resolve C++ constructor calls and index pure virtual methods, Scala companions and Dart extension types
feat(resolve): record methods passed as callback values as function references
fix(resolve): enforce cross-file visibility for C statics, private JVM/Swift/Scala/Dart/PHP, Go package-local and Rust module-private definitions
fix(resolve): refuse unproven receivers for call results, bare JS and Go calls, this.field and awaited values
fix(resolve): bind Rust self.method() to its impl owner and keep sealed JS modules off cross-file targets
fix(resolve): stop function-like C/C++ macros and aggregates from fabricating calls
feat(cli): group callers, callees and impact by definition and report truncation
feat(cli): accept line-numbered file selectors in node
feat(cli): report committed but unindexed changes in status and warn on collapsed parses
feat(mcp): keep explicit projectPath projects live-synced through the shared daemon
feat(install): honor CLAUDE_CONFIG_DIR and CODEX_HOME, write native OpenCode 2 entries and keep Explore loaded
fix(prompt-hook): cap injections at 9,000 bytes and skip task-notification envelopes
fix(daemon): allow one long-lived writer per project with a kernel lock
fix(store): rebind edges atomically during incremental sync
fix(index): refuse to retarget an initialized ancestor from an explicit child path
perf(resolve): build per-file source facts once per pass instead of rescanning files per reference
END_COMMIT_OVERRIDE
🤖 Generated with Claude Code