Repository navigation
build: update the pinned Rust toolchain to 1.98.0 - #292
Merged
Merged
Conversation
rust-toolchain.toml, every CI and release job, the scaffold placeholder, and the MSRV (Cargo rust-version and clippy msrv) move from 1.96 to 1.98 together, as #271 set them. Local shells that export RUSTUP_TOOLCHAIN=1.98.0 now build with the toolchain CI uses.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 161 161
Lines 99130 99130
=======================================
Hits 94484 94484
Misses 4646 4646 🚀 New features to boost your workflow:
|
This was referenced Oct 1, 2026
Merged
sunerpy
added a commit
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pinned Rust toolchain moves from 1.96.0 to 1.98.0, at the owner's request on 2026-10-01.
rust-toolchain.tomlchannel = "1.98.0".github/workflows/ci.ymldtolnay/rust-toolchainstep (7) →toolchain: 1.98.0.github/workflows/release.ymldtolnay/rust-toolchainstep (3) →toolchain: 1.98.0.github/scaffold.jsonRUST_TOOLCHAINplaceholder →1.98.0Cargo.tomlrust-version = "1.98"clippy.tomlmsrv = "1.98"The MSRV moves with the pin, the way #271 set them. Nothing in CI builds an older toolchain, so an MSRV of 1.96 would be an untested claim. As a result, building from source (
cargo install --git) now needs Rust 1.98 or newer. The release binaries are unaffected.Why now: this shell exports
RUSTUP_TOOLCHAIN=1.98.0, which overridesrust-toolchain.toml. Local gates therefore ran 1.98 while CI ran 1.96. #291 hit this when CI's 1.96 clippy rejected code that 1.98's clippy accepts. With this PR, local and CI use the same toolchain.The only remaining
1.96in the tree is an example inside a comment in.aws/buildspec/windows.yml. It documents a>= 1.85version check and is not a pin.Verification
env -u RUSTUP_TOOLCHAIN make pre-ciatcb92dfe, with a clean tree, sorust-toolchain.tomlselects the toolchain: rustc 1.98.0, clippy 0.1.98.-D warningspasses withmsrv = "1.98";pre-ci exit=0.The toolchain-only change has no product behavior to test first.
🤖 Generated with Claude Code