docs(design): settle the theme and ligature rows of the deviation table - #302
Merged
Merged
Conversation
Section 12 still said direction D was dark only, with a light variant an open question, and left ligatures as an open rule. Section 3.6 specifies Daylight without boards and the viewer ships both themes; the viewer turns ligatures off, as recorded in section 13.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 197 197
Lines 108387 108387
=======================================
Hits 103023 103023
Misses 5364 5364 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A docs-only follow-up to #301, acting on the final goal review's remaining note.
#301 updated the spec's Status line and §13, but the §12 deviation table in
docs/design/viewer-d.mdstill contradicted the build in two rows:D · Nebula); a light variant is an open question". It now says the boards are dark, the light setD · Daylightis specified in §3.6 without boards, and the viewer ships both.The rest of the spec is unchanged.
Verification
make fmt-checkandmake docs-checkpass. There is no code change.🤖 Generated with Claude Code