Skip to content

test(cli): stop the viewer when a test fails #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunerpy merged 1 commit into from
Oct 3, 2026
Merged

test(cli): stop the viewer when a test fails #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions crates/codegraph-cli/tests/cli_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ impl Viewer {
break;
}
}
Err(_) => {
let _ = viewer.child.kill();
panic!("codegraph ui never printed a URL:\n{}", viewer.output);
}
Err(_) => panic!("codegraph ui never printed a URL:\n{}", viewer.output),
}
}
viewer
Expand All @@ -148,7 +145,16 @@ impl Viewer {
true
}

fn stop(mut self) {
fn stop(self) {
drop(self);
}
}

/// A failing assertion unwinds through here too. `Child` neither kills nor
/// waits when dropped, so without this a test that fails while its server
/// runs leaves that server running after the test binary exits.
impl Drop for Viewer {
fn drop(&mut self) {
let _ = self.child.kill();
let _ = self.child.wait();
}
Expand Down
Loading