fix: preserve root component keys in back-references - #2400
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
ResolverCachecan resolve an external back-reference from an external component to a component in the original root document.ExternalRefProcessorpreviously continued into component-name allocation after that lookup. When the root component was itself an external$refand its declared key differed from the target filename, the allocator treated the root component as a conflict, created a suffixed duplicate, and could mutate the root snapshot. WithresolveFullyandvalidateExternalRefs, this later produced an invalid basename-derived lookup.This PR:
Fixes #2399
Type of Change
Checklist
Screenshots / Additional Context
Validated with:
mvn --batch-mode packagebuild on Java 11